Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QEMU] Add number of cores, target list for build #8156

Merged
merged 10 commits into from
Jun 7, 2021
Merged

[QEMU] Add number of cores, target list for build #8156

merged 10 commits into from
Jun 7, 2021

Conversation

mehrdadh
Copy link
Member

@mehrdadh mehrdadh commented May 27, 2021 •
edited
Loading

This PR:

  • Adds number of core variable to docker/install/ubuntu_install_qemu script
  • And adds target list as optional input argument

@mehrdadh
Copy link
Member Author

cc @areusch @leandron

@mehrdadh mehrdadh changed the title [Docker] Add environment variable for number of cores [QEMU] Add number of cores, target list for build May 28, 2021
areusch
areusch requested changes May 28, 2021
View reviewed changes
docker/install/ubuntu_install_qemu.sh Outdated Show resolved Hide resolved
docker/install/ubuntu_install_qemu.sh Show resolved Hide resolved
docker/install/ubuntu_install_qemu.sh Outdated Show resolved Hide resolved
docker/install/ubuntu_install_qemu.sh Outdated Show resolved Hide resolved
docker/install/ubuntu_install_qemu.sh Outdated Show resolved Hide resolved
docker/install/ubuntu_install_qemu.sh Show resolved Hide resolved
areusch
areusch reviewed Jun 4, 2021
View reviewed changes
Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sorry one more question, then looks good!

docker/install/ubuntu_install_qemu.sh Outdated Show resolved Hide resolved
@areusch areusch merged commit 364bc1b into apache:main Jun 7, 2021
@areusch
Copy link
Contributor

areusch commented Jun 7, 2021

thanks @mehrdadh , the PR is now merged!

@mehrdadh mehrdadh deleted the ci_qemu branch June 7, 2021 16:29
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 17, 2021
@mehrdadh
[QEMU] Add number of cores, target list for build (apache#8156)
65aa2c1 
* num of cores

* add target list

* comments

* cleanup

* cleanup

* trigger

* address comment

* comments
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 17, 2021
@mehrdadh @trevor-m
[QEMU] Add number of cores, target list for build (apache#8156)
538f6b3 
* num of cores

* add target list

* comments

* cleanup

* cleanup

* trigger

* address comment

* comments
@mbrookhart mbrookhart mentioned this pull request Jun 23, 2021
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkonolige tkonolige tkonolige left review comments

@areusch areusch areusch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mehrdadh @areusch @tkonolige